Compatibiliy with upstream vllm-project/vllm repository #5
Conversation
Signed-off-by: Yannick Schnider <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: Yannick Schnider <[email protected]>
Signed-off-by: Yannick Schnider <[email protected]>
yannicks1
force-pushed
the
ysc-fix-upstream-compatibility
branch
2 times, most recently
from
26f24c9 to
c75903e
Compare
Dockerfile.spyre
Outdated
| && pip install -r requirements-build.txt \ | ||
| && pip install --no-build-isolation -v -e . \ | ||
| && mkdir /workspace/vllm-spyre | ||
| RUN pip${PYTHON_VERSION} install vllm==0.7.3 |
There was a problem hiding this comment.
I suspect this is why spyre tests are still failing
| RUN pip${PYTHON_VERSION} install vllm==0.7.3 | |
| RUN pip${PYTHON_VERSION} install --upgrade pip && pip install vllm==0.7.3 |
sducouedic
left a comment
sducouedic
left a comment
There was a problem hiding this comment.
Thanks for fixing the python version! This looks good to me.
Signed-off-by: Yannick Schnider <[email protected]>
yannicks1
force-pushed
the
ysc-fix-upstream-compatibility
branch
from
cc7dd6f to
ac12781
Compare
Signed-off-by: Yannick Schnider <[email protected]>
Ensuring compatibility with the latest upstream release
v.0.7.3. Since there has been a new abstract method introduced in the base model runner, we have to define it in the Spyre model runner which inherits from the base class.changes:
get_model()function inSpyreModelRunneras required by abstract base classModelRunnerBase(link to upstream base class abstract method)vllm-spyre/core/scheuduler.pywith the upstream schedulerv.0.7.3.# SPYRE SPECIFIC CODE BLOCK STARTand# SPYRE SPECIFIC CODE BLOCK ENDto mark the Spyre specific code blocks.python->python${PYTHON_VERSION}andpip->pip${PYTHON_VERSION}to only have the python version hard coded in the docker file:ARG PYTHON_VERSION=3.12Tested vllm-spyre plugin with release
v.0.7.3(commit) on Spyre successfully.